[PATCH] D148787: [llvm-debuginfo-analyzer] Add combined selection for logical elements.

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added a comment.

I've got a reasonable amount of confusion here -- what's currently line 634 reads "for more specific combined criterias", and further up you agree that the point of the option is to "filter" and reduce the number of elements presented. However the explanatory text,

  A logical element, line, scope, symbol or type will be selected if their name or line number matches any of the given <pattern>s **and** their <kind> or <condition> matches any of the given <kind>s or <condition>s.

actually broadens the number of elements presented: given that only one "--select" pattern needs to be matched, additional "--select" patterns will expand the number of elements presented, and it's the same for the "kind" selections. Am I misunderstanding this or are the two opposed; and if so, which is it supposed to be? I can see use-cases for both behaviours.



================
Comment at: llvm/include/llvm/DebugInfo/LogicalView/Core/LVOptions.h:512-520
+  // 'SelectCombinedPattern' is set when one or more of the '--select-xxx'
+  // and at least one '--select' options are specified in the command line,
+  // with '--select-xxx' being:
+  //   --select-elements, --select-lines,  --select-scopes
+  //   --select-symbols, --select-types`
+  //
+  // There are 2 cases for the combined selection matching, with target being:
----------------
This feels more like documentation for the option, rather than the following function, `resolveGenericPatternMatch` -- it's the purpose of the function that's unclear to me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148787/new/

https://reviews.llvm.org/D148787