[PATCH] D147408: [AMDGPU] Iterative scan implementation for atomic optimizer.

[Pravin Jagtap via Phabricator via llvm-commits]

pravinjagtap added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAtomicOptimizer.cpp:759
+  // Control flow is changed here after splitting I's block
+  assert(DTU.getDomTree().verify(DominatorTree::VerificationLevel::Fast));
+
----------------
arsenm wrote:
> Won't the regular post-pass verifier catch this?
> Won't the regular post-pass verifier catch this?

Yes, During my experimentation I found that `-verify-dom-info` is not catching the issues related to updates required in dominator tree (both with opt and llc). Although, `assert` here is giving desired behavior.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147408/new/

https://reviews.llvm.org/D147408