[PATCH] D152227: [X86] Prefer vmovmsk instead of vtest for alderlake.

[Phoebe Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: llvm/lib/Target/X86/X86.td:425
 //===----------------------------------------------------------------------===//
+def TuningSlowVtest : SubtargetFeature<"slow-vtest", "HasSlowVtest", "true",
+                                       "VTEST instruction is slow">;
----------------
Should be `Is`?


================
Comment at: llvm/lib/Target/X86/X86.td:426
+def TuningSlowVtest : SubtargetFeature<"slow-vtest", "HasSlowVtest", "true",
+                                       "VTEST instruction is slow">;
 
----------------
LuoYuanke wrote:
> goldstein.w.n wrote:
> > Personally think slowvtest is a kind of confusing name b.c vtest also has a perf dropoff from SnB -> HSW.
> > Maybe "PreferMovmskOverVTest" would be clearer?
> I just follow the previous naming convention. I'm open to "PreferMovmskOverVTest". @RKSimon and @pengfei, what's your opinion?
I think we should start from `Tuning`, but `TuningPreferMovmskOverVTest` looks verbose..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152227/new/

https://reviews.llvm.org/D152227