[PATCH] D144911: adding bf16 support to NVPTX

[Artem Belevich via Phabricator via llvm-commits]

tra added inline comments.


================
Comment at: llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp:615
     setFP16OperationAction(Op, MVT::v2f16, Legal, Expand);
-  }
-
-  for (const auto &Op : {ISD::FADD, ISD::FMUL, ISD::FSUB, ISD::FMA}) {
     setBF16OperationAction(Op, MVT::bf16, Legal, Promote);
     setBF16OperationAction(Op, MVT::v2bf16, Legal, Expand);
----------------
There's still something odd with this patch. The `setBF16OperationAction` is not in the upstream, but it does not show up in the diff on phabricator. 

Please do rebase on top of the LLVM and make sure that all your changes are on the git branch you use to send the patch to phabricator. If in doubt how to get `arc` to do it correctly, you can always create and upload the diff manually as described here: https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface


================
Comment at: llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp:689
     setFP16OperationAction(Op, MVT::f16, GetMinMaxAction(Expand), Expand);
+    setFP16OperationAction(Op, MVT::bf16, GetMinMaxAction(Expand), Expand);
     setOperationAction(Op, MVT::f32, GetMinMaxAction(Expand));
----------------
Should it be `set*BF*16OperationAction` ?


================
Comment at: llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp:692
     setFP16OperationAction(Op, MVT::v2f16, GetMinMaxAction(Expand), Expand);
-  }
-  for (const auto &Op : {ISD::FMINNUM, ISD::FMAXNUM}) {
-    setBF16OperationAction(Op, MVT::bf16, GetMinMaxAction(Promote), Promote);
-    setBF16OperationAction(Op, MVT::v2bf16, GetMinMaxAction(Expand), Expand);
-    setBF16OperationAction(Op, MVT::bf16, GetMinMaxAction(Expand), Expand);
-    setBF16OperationAction(Op, MVT::v2bf16, GetMinMaxAction(Expand), Expand);
+    setFP16OperationAction(Op, MVT::v2bf16, GetMinMaxAction(Expand), Expand);
   }
----------------
ditto.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144911/new/

https://reviews.llvm.org/D144911