[PATCH] D152081: [Attributor] Add lightweight version for attribute deduction only. (WIP)

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 3 14:12:26 PDT 2023


goldstein.w.n added a comment.

re:

> There's an instcombine
> patch D151943 <https://reviews.llvm.org/D151943> that attempts to extend InstCombine to do that. IMO it
> would probably preferable to do it directly when deriving the
> attributes. That means either switching to attributor or extending
> FunctionAttrs.

I think that makes sense, the only semi concern is FunctionAttr (and lesser
degree attributor) are IPO. Deducing for a callsite within a function is
inherently local. If the IPO passes will always be on and definetly run
before inlining I have no gripes, but if thats not always the case think it
may pay to split up callsite inference from function attr inference.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152081/new/

https://reviews.llvm.org/D152081



More information about the llvm-commits mailing list