[PATCH] D151979: [RISCV] Handle "o" inline asm memory constraint

Wang Pengcheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 2 01:36:21 PDT 2023


pcwang-thead marked an inline comment as done.
pcwang-thead added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/inline-asm.ll:116
+; RV64I-NEXT:    ret
+  call void asm sideeffect "", "=*o"(ptr elementtype(i32) %a)
+  ret void
----------------
jrtc27 wrote:
> The implementation could be completely broken and this would be none the wiser. You need to test the implementation actually lowers it to something sensible, not that it doesn't crash.
These tests are the same as constraint "m" now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151979/new/

https://reviews.llvm.org/D151979



More information about the llvm-commits mailing list