[PATCH] D151863: [x86][MC] Fix movdir64b addressing

Akshay Khadse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 1 21:47:43 PDT 2023


akshaykhadse added inline comments.


================
Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:1781
+  // value at this time.
+  BaseReg = BaseReg ? BaseReg : 0;
   Operands.push_back(X86Operand::CreateMem(
----------------
craig.topper wrote:
> This sets BaseReg to 0 if its already 0?
Oops. Is this even required? I think we can get rid of this. There are no tests that failed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151863/new/

https://reviews.llvm.org/D151863



More information about the llvm-commits mailing list