[PATCH] D151898: [RISCV] Guard Advance Interrupt Architecture CSRs with Smaia and Ssaia extensions.
Jessica Clarke via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 1 12:10:54 PDT 2023
jrtc27 requested changes to this revision.
jrtc27 added a comment.
This revision now requires changes to proceed.
I don't think we want to do this. There's precedent for making all CSRs always visible, and it does little harm to expose them. Requiring OSes to specify -march=ssfoo_ssbar_ssbaz_... to do anything useful is just a waste of everyone's time IMO, and often wrong because OSes don't want to //require// those extensions, they just want to //support// them if present, so then you instead have to `.option arch, +ssfoo` all over the place. Or people will just use the numeric values instead of the names, which then makes the code less readable.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151898/new/
https://reviews.llvm.org/D151898
More information about the llvm-commits
mailing list