[PATCH] D151022: [llvm-exegesis] Introduce SubprocessMemory Utility Class

[Aiden Grossman via Phabricator via llvm-commits]

aidengrossman added inline comments.


================
Comment at: llvm/unittests/tools/llvm-exegesis/X86/SubprocessMemoryTest.cpp:83
+  SubprocessMemory SM =
+      testCommon({{"test1", {APInt(48, 0xaabbccddeeff), 4096, 0}}});
+  std::vector<uint8_t> Test1Expected(512, 0);
----------------
courbet wrote:
> If you want to support fractional sizes should add a test for it.
This is the test case for fractional sizes. The value is six bytes, so it gets truncated at the end and has to through the fractional size handling path. I can add more test cases though if you feel more coverage is needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151022/new/

https://reviews.llvm.org/D151022