[PATCH] D151602: [TableGen] Add !getdagarg and !getdagname

Tue May 30 09:11:57 PDT 2023

hliao added a comment.

In D151602#4380256 <https://reviews.llvm.org/D151602#4380256>, @simon_tatham wrote:

> It's not quite clear whether you mean this patch to be an alternative to D151457 <https://reviews.llvm.org/D151457>, or to go together with it. The two changes would clearly conflict, but one of your comments in the other change (https://reviews.llvm.org/D151457#4374848) made it sound as if you meant to do both?
>
> If they're alternatives, then I prefer this one, because I love the extra feature of looking up a dag argument by its name instead of its index. I can see that being really useful.

Originally, I thought to provide this element access functionality as complementary to the `!getdagargs`. But, I realized later that the element accessor is more convenient to be used. Also, `!getdagargs` could be implemented through `!getdagarg` with the help of `!forall` and `!size`, even though a little bit verbose. That makes the D151457 <https://reviews.llvm.org/D151457> redundant. I prefer this one and want to check your comment and suggestion. I will cancel D151457 <https://reviews.llvm.org/D151457> once we all agree on that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151602/new/

https://reviews.llvm.org/D151602