[llvm] cafb099 - [AMDGPU] Silence gcc warning [NFC]

Mikael Holmen via llvm-commits llvm-commits at lists.llvm.org
Fri May 26 01:18:31 PDT 2023


Author: Mikael Holmen
Date: 2023-05-26T10:17:59+02:00
New Revision: cafb0991a297bfad07f0e60a895f7fdfb7ec9c60

URL: https://github.com/llvm/llvm-project/commit/cafb0991a297bfad07f0e60a895f7fdfb7ec9c60
DIFF: https://github.com/llvm/llvm-project/commit/cafb0991a297bfad07f0e60a895f7fdfb7ec9c60.diff

LOG: [AMDGPU] Silence gcc warning [NFC]

Without the fix gcc complains with
 ../lib/Target/AMDGPU/SIWholeQuadMode.cpp:1543: warning: enumeral and non-enumeral type in conditional expression [-Wextra]
  1542 |     unsigned CopyOp = MI->getOperand(1).isReg()
       |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  1543 |                           ? AMDGPU::COPY
       |                           ~~~~~~~~~~~~~~
  1544 |                           : TII->getMovOpcode(TRI->getRegClassForOperandReg(
       |                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  1545 |                                 *MRI, MI->getOperand(0)));
       |

Added: 
    

Modified: 
    llvm/lib/Target/AMDGPU/SIWholeQuadMode.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/AMDGPU/SIWholeQuadMode.cpp b/llvm/lib/Target/AMDGPU/SIWholeQuadMode.cpp
index d8c54056db18..e22b950ce897 100644
--- a/llvm/lib/Target/AMDGPU/SIWholeQuadMode.cpp
+++ b/llvm/lib/Target/AMDGPU/SIWholeQuadMode.cpp
@@ -1540,7 +1540,7 @@ void SIWholeQuadMode::lowerCopyInstrs() {
     }
 
     unsigned CopyOp = MI->getOperand(1).isReg()
-                          ? AMDGPU::COPY
+                          ? (unsigned)AMDGPU::COPY
                           : TII->getMovOpcode(TRI->getRegClassForOperandReg(
                                 *MRI, MI->getOperand(0)));
     MI->setDesc(TII->get(CopyOp));


        


More information about the llvm-commits mailing list