[PATCH] D151019: [llvm-exegesis] Refactor FunctionExecutorImpl and create factory

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 24 00:25:29 PDT 2023


courbet accepted this revision.
courbet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/tools/llvm-exegesis/lib/BenchmarkRunner.h:128
+  Expected<std::unique_ptr<FunctionExecutor>>
+  getFunctionExecutor(object::OwningBinary<object::ObjectFile> Obj,
+                      const BenchmarkKey &Key) const;
----------------
[nit] `createFunctionExecutor` ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151019/new/

https://reviews.llvm.org/D151019



More information about the llvm-commits mailing list