[PATCH] D143463: [X86] Use the CFA when appropriate for better variable locations around calls.

[Jeremy Morse via Phabricator via llvm-commits]

jmorse accepted this revision.
jmorse added a comment.

Sorry for having missed this; it sounds like a good direction to take, and will fix various variable locations.

Just to confirm my understanding, this should have no interaction with the shrink-wrapping optimisation pass because there shouldn't be any stack-stored variables before frame setup occurs, yes?



================
Comment at: llvm/test/DebugInfo/X86/stack_adjustments_trigger_cfa_frame_base.ll:143-146
+attributes #0 = { inlinehint nonlazybind uwtable "probe-stack"="__rust_probestack" "target-cpu"="x86-64" }
+attributes #1 = { noinline nonlazybind uwtable "probe-stack"="__rust_probestack" "target-cpu"="x86-64" }
+attributes #2 = { nonlazybind uwtable "probe-stack"="__rust_probestack" "target-cpu"="x86-64" }
+attributes #3 = { nocallback nofree nosync nounwind readnone speculatable willreturn }
----------------
NB -- if these attributes aren't necessary for the test to operate, it's better to remove them to avoid future maintenance burdens


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143463/new/

https://reviews.llvm.org/D143463