[PATCH] D151029: [DAG] Combine insert(shuffle(load), load, 0) into a single load

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:20993
+  SDValue Ptr = ScalarLoad->getBasePtr();
+  if (InsIndex != 0)
+    Ptr = DAG.getNode(ISD::ADD, DL, Ptr.getValueType(), VecLoad->getBasePtr(),
----------------
RKSimon wrote:
> Is all this correct for big-endian?
I believe so. I originally had this disabled for bigendian, but as far as I can tell it is OK as we are always dealing with elements of the same size, which will be in the same positions between big and little endian. Let me know if that doesn't sound right.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151029/new/

https://reviews.llvm.org/D151029