[PATCH] D150947: [AMDGPU] Fix odd implicit operand handling in clause breaking

Sergei Barannikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 19 02:45:31 PDT 2023


barannikov88 added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp:605
 void GCNHazardRecognizer::addClauseInst(const MachineInstr &MI) {
-  // XXX: Do we need to worry about implicit operands
-  addRegsToSet(TRI, MI.defs(), ClauseDefs);
-  addRegsToSet(TRI, MI.uses(), ClauseUses);
+  addRegsToSet(TRI, MI.operands(), ClauseDefs, ClauseUses);
 }
----------------
(nit) Could be inlined.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150947/new/

https://reviews.llvm.org/D150947



More information about the llvm-commits mailing list