[PATCH] D149590: ValueTracking: Implement computeKnownFPClass for ldexp

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/include/llvm/Analysis/ValueTracking.h:368
+  // to be quieted but cannot be introduced.
+  void propagateNaN(const KnownFPClass &Src, bool PreserveSign = false) {
+    if (Src.isKnownNever(fcNan)) {
----------------
Rebase to pick this up from trunk


================
Comment at: llvm/include/llvm/Analysis/ValueTracking.h:378
+  /// Propagate knowledge from a source value that could be a denormal or zero
+  /// depending copied to the result. We have to be conservative since output
+  /// flushing is not guaranteed, so known-never-zero may not hold.
----------------
Typo "depending copied"? Not sure what was meant


================
Comment at: llvm/include/llvm/Analysis/ValueTracking.h:384
+  /// canonicalizing operation. We can assume signaling nans will not be
+  /// introduced, but cannot assume a denormal will be flushed under with
+  /// FTZ/DAZ.
----------------
Typo "flushed under"?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149590/new/

https://reviews.llvm.org/D149590