[PATCH] D150797: Turn unreachable error into assert

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added a comment.

In D150797#4352145 <https://reviews.llvm.org/D150797#4352145>, @jhenderson wrote:

> Given that there are unit tests, this code is in the library's public-facing API. Does removing the error check cause problems if users happen to be leveraging the FileCheck library in some manner?

It is in the library but not exposed in the FileCheck library header. The unit tests use the FileCheck internal header. The library interface is much higher level than that: it is essentially composed of the readCheckFile and checkInput functions. Everything else is internal.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150797/new/

https://reviews.llvm.org/D150797