[PATCH] D150369: TypeFinder: collect target types

Sebastian Neubauer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 17 04:24:05 PDT 2023


Flakebi added a comment.

Looks good to me. One question/nit inline.



================
Comment at: llvm/include/llvm/IR/TypeFinder.h:72
+
+  StructType *&getStructType(unsigned Idx) { return StructTypes[Idx]; }
+
----------------
As a getter, this should probably return `StructType *` instead of a reference?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150369/new/

https://reviews.llvm.org/D150369



More information about the llvm-commits mailing list