[PATCH] D149889: [TTI] Use users of GEP to guess access type in getGEPCost

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 17 03:49:53 PDT 2023


asb added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:286
 
   /// Estimate the cost of a GEP operation when lowered.
   InstructionCost
----------------
Perhaps it's worth expanding the doc comment to explain how AccessTypes may be used? e.g. "Callers may pass in the access type of users of the GEP in order to allow a more accurate cost, for instance on targets where the legal addressing modes are different for different types."

Of course personal tastes on the amount of doc comments to provide can vary....


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149889/new/

https://reviews.llvm.org/D149889



More information about the llvm-commits mailing list