[PATCH] D150416: [RISCV] Add a pass to combine `cm.pop` and `ret` insts

KaiYi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 17 00:58:41 PDT 2023


KYG added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.h:134
 
+  std::optional<DestSourcePair> isLoadImmImpl(const MachineInstr &MI) const;
+
----------------
Could we just use `isCopyInstrImpl` instead?
Since it's doing almost the same thing, and there's no prototype in TargetInstrInfo.h.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150416/new/

https://reviews.llvm.org/D150416



More information about the llvm-commits mailing list