[PATCH] D150675: [AMDGPU] Rewrite device ctor / dtor handling to use .init / .fini sections

Tue May 16 08:52:11 PDT 2023

yaxunl added inline comments.

================
Comment at: llvm/test/CodeGen/AMDGPU/lower-ctor-dtor-constexpr-alias.ll:1
 ; RUN: opt -S -mtriple=amdgcn-amd-amdhsa -mcpu=gfx900 -amdgpu-lower-ctor-dtor %s | FileCheck %s

----------------
jhuber6 wrote:
> yaxunl wrote:
> > can we add a check that __init_array_start and __init_array_end are created by lld as expected?
> That might be a little tough since `lld` is a separate project that might not be built. There are tests for it in there though, but it would be best to know for sure. Might need to be a runtime test? For now you can just take my word for it since it's what we use in the `libc` tests which have a buildbot https://lab.llvm.org/staging/#/builders/247.
OK. LGTM

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150675/new/

https://reviews.llvm.org/D150675