[PATCH] D150422: [ConstantFolding] fold integers whose bitwidth is greater than 63.

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 16 01:20:00 PDT 2023


nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM

> [ConstantFolding] fold integers whose bitwidth is greater than 63.

This should say 64.

In D150422#4344395 <https://reviews.llvm.org/D150422#4344395>, @khei4 wrote:

> BTW, if non-byte-integers loading by a different size integer type is undefined, language reference seems to say nothing about it, at least integer <https://llvm.org/docs/LangRef.html#integer-type> and load <https://llvm.org/docs/LangRef.html#id208> sections. Is this a room to add a note? or I missed some related sections?

This is specified in https://llvm.org/docs/LangRef.html#id209 and https://llvm.org/docs/LangRef.html#id214. But current semantics are not really clear/inconsistent, see also discussion on D123991 <https://reviews.llvm.org/D123991>.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150422/new/

https://reviews.llvm.org/D150422



More information about the llvm-commits mailing list