[PATCH] D150609: [AMDGPU] Do not assume stack size for PAL code object indirect calls

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 15 14:12:29 PDT 2023


arsenm added a comment.

Is



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUResourceUsageAnalysis.cpp:120-122
+  if (AMDGPU::getCodeObjectVersion(M) >= AMDGPU::AMDHSA_COV5 &&
+      !AssumedStackSizeForDynamicSizeObjects.getNumOccurrences())
+      AssumedStackSizeForDynamicSizeObjects = 0;
----------------
Dynamic objects should be treated identically 


================
Comment at: llvm/test/CodeGen/AMDGPU/resource-usage-pal.ll:1
+; RUN llc -mtriple=amdgcn-amd-amdpal -mcpu=gfx1100 -verify-machineinstrs < %s | FileCheck %s
+
----------------
Can you just add a run line to an existing test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150609/new/

https://reviews.llvm.org/D150609



More information about the llvm-commits mailing list