[PATCH] D149699: [InstCombine] Improve bswap optimization

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 15 12:41:46 PDT 2023


goldstein.w.n added a comment.

In D149699#4343367 <https://reviews.llvm.org/D149699#4343367>, @austin880625 wrote:

> Sorry if inappropriate, but does this patch need further actions/improvement on my side?

Sorry! I've been dragging my feet on this. It looks good. I will test this and the DAGCombiner patch today/tonight.
If you haven't heard back in 24hr ping back.

Its not inappropriate at all to ping. roughly once a week is appropriate at all times unless there are
unaddressed feedbacks to already handle. Sometime more often is appropriate as well if its say for
an urgent bug.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149699/new/

https://reviews.llvm.org/D149699



More information about the llvm-commits mailing list