[PATCH] D150488: [MemProf] Set hot/cold new values with option

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 12 15:17:51 PDT 2023


tejohnson added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp:62
+
+  bool parse(cl::Option &O, StringRef ArgName, StringRef Arg, unsigned &Value) {
+    if (Arg.getAsInteger(0, Value))
----------------
davidxl wrote:
> Is 0 allowed ?
Yes. The 0 value to getAsInteger is the radix value, and 0 means autosense (so it will accept e.g. hex, octal, etc with the appropriate prefix on the value).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150488/new/

https://reviews.llvm.org/D150488



More information about the llvm-commits mailing list