[PATCH] D145343: [AMDGPU] Emit predefined macro `__AMDGCN_CUMODE__`

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:121-123
+def warn_drv_unsupported_option_for_processor : Warning<
+  "ignoring '%0' option as it is not currently supported for processor '%1'">,
+  InGroup<OptionIgnored>;
----------------
I'm surprised there already isn't a warning for this?


================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:146
+    return false;
+  return TargetFeature == "no-cumode";
+}
----------------
I don't understand the use of "no-cumode". Where is this defined?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145343/new/

https://reviews.llvm.org/D145343