[PATCH] D142479: [AIX] support 64bit global symbol table for big archive

Digger Lin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 11 13:20:23 PDT 2023


DiggerLin marked an inline comment as done.
DiggerLin added inline comments.


================
Comment at: llvm/lib/Object/ArchiveWriter.cpp:876
     // symbol table.
     printWithSpacePadding(Out, NewMembers.size() ? GlobalSymbolOffset : 0, 20);
+    printWithSpacePadding(Out, GlobalSymbolOffset64, 20);
----------------
stephenpeckham wrote:
> No need to check NewMembers.size().  GlobalSymbolOffset will be 0 if there are no members.
agree. thanks, I will modify it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142479/new/

https://reviews.llvm.org/D142479



More information about the llvm-commits mailing list