[PATCH] D149575: [CodeGen] Support allocating of arguments by decreasing offsets

Sergei Barannikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 9 09:51:59 PDT 2023


barannikov88 added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/CallingConvLower.h:177-178
   LLVMContext &Context;
+  // True if arguments should be allocated at negative offsets.
+  bool NegativeOffsets;
 
----------------
arsenm wrote:
> Is this really any different from StackGrowsUp/Down?
`NegativeOffsets == true` should be equivalent to `StackGrowsUp`,
but this is not the case for AMDGPU, which allocates objects at positive offsets.
I remember you saying it may change in the future. If that happens, this flag can be removed.

(I've update the description, it used the wrong terms.)



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149575/new/

https://reviews.llvm.org/D149575



More information about the llvm-commits mailing list