[PATCH] D138526: [SimpleLoopUnswitch] unswitch selects

[Dávid Bolvanský via Phabricator via llvm-commits]

xbolva00 added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/SimpleLoopUnswitch.cpp:3504
+    // instructions with a poison conditional do not propagate poison, but
+    // branching on on poison causes UB. Insert a freeze on the select
+    // condtional to prevent UB after turning the select into a branch.
----------------
on on -> on


================
Comment at: llvm/lib/Transforms/Scalar/SimpleLoopUnswitch.cpp:3505
+    // branching on on poison causes UB. Insert a freeze on the select
+    // condtional to prevent UB after turning the select into a branch.
+    InsertFreeze = !isGuaranteedNotToBeUndefOrPoison(
----------------
condtional -> conditional 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138526/new/

https://reviews.llvm.org/D138526