[PATCH] D150107: [X86] Remove patterns for shift/rotate with immediate 1 and update side effect

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 8 20:05:44 PDT 2023


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrShiftRotate.td:365
 
-let mayStore = 1 in {
+let mayLoad = 1, mayStore = 1 in {
 let Uses = [EFLAGS], SchedRW = [WriteRotateLd, WriteRMW] in {
----------------
I think this line is the one that affected the llvm-mca tests. You can go ahead and commit that and the the llvm-mca test changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150107/new/

https://reviews.llvm.org/D150107



More information about the llvm-commits mailing list