[PATCH] D150107: [X86] Remove patterns for shift/rotate with immediate 1 and update side effect

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/test/tools/llvm-mca/X86/AlderlakeP/resources-x86_64.s:1518
 # CHECK-NEXT:  3      2     1.00                        rcrb	%dil
-# CHECK-NEXT:  6      13    1.00           *            rclb	(%rax)
-# CHECK-NEXT:  6      13    1.00           *            rcrb	(%rax)
+# CHECK-NEXT:  6      13    1.00    *      *            rclb	(%rax)
+# CHECK-NEXT:  6      13    1.00    *      *            rcrb	(%rax)
----------------
craig.topper wrote:
> craig.topper wrote:
> > I think you need to `let mayLoad = 0`
> Err nevermind
This should really be a different patch. This is an existing bug independent of whether removing the patterns gets approved.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150107/new/

https://reviews.llvm.org/D150107