[PATCH] D150148: [IPO] Opt-in local clones for thinlto imports

[Snehasish Kumar via Phabricator via llvm-commits]

snehasish added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/ElimAvailExtern.cpp:60
+  // module identifier.
+  auto NewName = OrigName + ".__clone__" + getUniqueModuleId(M);
+  F.setName(NewName);
----------------
mtrofin wrote:
> snehasish wrote:
> > Should we teach sample prof [1] about this new suffix too? On the other hand from the comment it seems like reusing the "__uniq" suffix might be another option?
> > 
> > [1] https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/ProfileData/SampleProf.h#L1079-L1083
> The name could have `__uniq` already; hmm... if we use `__uniq` here, too, it seems like that's all that'd be needed for teaching sample prof, right?
Yeah, that's my understanding.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150148/new/

https://reviews.llvm.org/D150148