[PATCH] D150004: [RISCV] .debug_line: emit relocations for assembly input files

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 8 12:59:05 PDT 2023


reames added inline comments.


================
Comment at: llvm/lib/MC/MCObjectStreamer.cpp:545
-  int64_t Res;
-  if (AddrDelta->evaluateAsAbsolute(Res, getAssemblerPtr())) {
-    MCDwarfLineAddr::Emit(this, Assembler->getDWARFLinetableParams(), LineDelta,
----------------
The code structure here makes it seem like evaluateAsAbsolute should be returning false in this case.  Removing the fastpath here certainly hides this bug, but do we have others lurking due to incorrect return results from evaluateAsAbsolute?

Not my area, so totally possible I'm off base here.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150004/new/

https://reviews.llvm.org/D150004



More information about the llvm-commits mailing list