[PATCH] D148872: [llvm-profdata] ProfileReader cleanup - preparation for MD5 refactoring - 2

Snehasish Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 8 09:50:49 PDT 2023


snehasish accepted this revision.
snehasish added a comment.
This revision is now accepted and ready to land.

LGTM, please wait a bit in case others have any concerns.



================
Comment at: llvm/lib/ProfileData/SampleProfReader.cpp:564
+    return SampleContext(*FContext);
+  } else {
+    auto FName(readStringFromTable());
----------------
Can we drop the else (and indentation for the block below) since this part is unconditional after the early return? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148872/new/

https://reviews.llvm.org/D148872



More information about the llvm-commits mailing list