[PATCH] D149855: [DAGCombiner] Avoid template for generalized pattern match.

[Yeting Kuo via Phabricator via llvm-commits]

fakepaper56 added a comment.

In D149855#4326180 <https://reviews.llvm.org/D149855#4326180>, @simoll wrote:

>> DAGCombiner.cpp may make the binary too large.
>
> Could you provide more details on this concern, eg where was it raised? To put this discussion in perspective, looking at vanilla LLVM 14, a debug build of `DAGCombiner.cpp.o` has `7MB` vs `1322MB` for `libLLVM-14.so` (with `X86`,`RISCV`). I would add that this approach adds virtual dispatch on the standard DAGCombiner path, which has a performance cost. IMHO, the question is what a good tradeoff would be.

Actually I didn't encounter any problems for the binary size and I just ignored the performance cost of virtual dispatch. After putting the cost of virtual dispatch into consideration, I think the trade-off problem is too big for me and maybe too early to be considered.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149855/new/

https://reviews.llvm.org/D149855