[PATCH] D149918: [InstCombine] Add oneuse checks to shr + cmp constant folds.
Dave Green via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun May 7 16:16:23 PDT 2023
dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.
I can verify that this fixes the issues, including the other one from https://reviews.llvm.org/D143624#4315468 that looks more difficult to reverse. It may be worth adding some tests like https://godbolt.org/z/cxKrfM4TK. But otherwise it LGTM. Getting more ILP sounds like something the backend should handle, if it is profitable given the constants.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149918/new/
https://reviews.llvm.org/D149918
More information about the llvm-commits
mailing list