[PATCH] D150068: [X86][AsmParser] Refactor code in AsmParser

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86InstrOptimization.cpp:1
+//===-- X86InstrOptimization.cpp - X86 MCInst optimization ------*- C++ -*-===//
+//
----------------
X86EncodingOptimixation might be a better name?


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86InstrOptimization.cpp:70
+    return false;
+  FROM_TO_RETURN(RCR8ri, RCR8r1)
+  FROM_TO_RETURN(RCR16ri, RCR16r1)
----------------
I think you could have a single argument and add the `i` or  `1` suffix inside the macro.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150068/new/

https://reviews.llvm.org/D150068