[PATCH] D149995: [test] [MCJIT] Don't overwrite config.unsupported to False

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 5 14:34:48 PDT 2023


mstorsjo created this revision.
mstorsjo added reviewers: sgraenitz, lhames.
Herald added a project: All.
mstorsjo requested review of this revision.
Herald added a project: LLVM.

An outer directory may have set config.unsupported to True for
a different reason, separate from architecture concerns - we
shouldn't force it back to False just because one criterion is
fulfilled.

This is a preparatory step before a second patch.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D149995

Files:
  llvm/test/ExecutionEngine/MCJIT/lit.local.cfg


Index: llvm/test/ExecutionEngine/MCJIT/lit.local.cfg
===================================================================
--- llvm/test/ExecutionEngine/MCJIT/lit.local.cfg
+++ llvm/test/ExecutionEngine/MCJIT/lit.local.cfg
@@ -1,21 +1,16 @@
 root = config.root
 targets = root.targets
-if ('X86' in targets) | ('AArch64' in targets) | ('ARM' in targets) | \
-   ('Mips' in targets) | ('PowerPC' in targets) | ('SystemZ' in targets):
-    config.unsupported = False
-else:
+if not (('X86' in targets) | ('AArch64' in targets) | ('ARM' in targets) | \
+   ('Mips' in targets) | ('PowerPC' in targets) | ('SystemZ' in targets)):
     config.unsupported = True
 
 # FIXME: autoconf and cmake produce different arch names. We should normalize
 # them before getting here.
 if root.host_arch not in ['i386', 'x86', 'x86_64', 'AMD64',
-                          'AArch64', 'ARM', 'Mips',
+                          'AArch64', 'ARM', 'armv7', 'Mips',
                           'PowerPC', 'ppc64', 'ppc64le', 'SystemZ']:
     config.unsupported = True
 
-if 'armv7' in root.host_arch:
-    config.unsupported = False
-
 if 'i386-apple-darwin' in root.target_triple:
     config.unsupported = True
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149995.519974.patch
Type: text/x-patch
Size: 1189 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230505/1f8971eb/attachment.bin>


More information about the llvm-commits mailing list