[PATCH] D149833: [X86] Omit predicate In64BitMode for instructions w/ GP64 operand in X86InstrArithmetic.td, NFCI

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 4 09:54:15 PDT 2023


craig.topper requested changes to this revision.
craig.topper added a comment.
This revision now requires changes to proceed.

None of these instructions have GPR operands to preventing parsing.



================
Comment at: llvm/lib/Target/X86/X86InstrArithmetic.td:602
   def INC32m : INCDECM<MRM0m, "inc", Xi32, 1>;
-} // Predicates
-let Predicates = [UseIncDec, In64BitMode] in {
   def INC64m : INCDECM<MRM0m, "inc", Xi64, 1>;
+} // CodeSize = 2, SchedRW, Predicates
----------------
This instruction doesn't have a GPR operand. It's just `incq (%rax)` If the pointer doesn't have any register or uses 32 bit registers what prevents it from parsing?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149833/new/

https://reviews.llvm.org/D149833



More information about the llvm-commits mailing list