[PATCH] D145634: [X86] Support llvm.{min,max}imum.f{16,32,64}

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:1006
+    setOperationAction(ISD::FMAXIMUM,           MVT::f32, Custom);
+    setOperationAction(ISD::FMINIMUM,           MVT::f32, Custom);
+
----------------
e-kud wrote:
> RKSimon wrote:
> > Do we have test coverage with SSE1 only?
> Apparently, no. There is a `fatal error: error in backend: Access past stack top!`  with `double`s and `+sse,-sse2`
> 
> It seems I need to split `float` and `double` tests into two separate files to test SSE1 only. Are there better alternatives?
I'd be very tempted to limit float maximum/minimum to SSE2 or later tbh


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145634/new/

https://reviews.llvm.org/D145634