[PATCH] D147963: [LV] Use VPValue for SCEV expansion in fixupIVUsers.

[Ayal Zaks via Phabricator via llvm-commits]

Ayal accepted this revision.
Ayal added a comment.
This revision is now accepted and ready to land.

LGTM, with some comments, also provided in D147964 <https://reviews.llvm.org/D147964>.



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:3384
+
+      VPValue *StepVPV = Plan.getSCEVExpansion(II.getStep());
+      Value *Step = StepVPV->getDefiningRecipe() ? State.get(StepVPV, 0)
----------------
nit: worth asserting that step SCEV is expected to have a VPValue?


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:3385-3386
+      VPValue *StepVPV = Plan.getSCEVExpansion(II.getStep());
+      Value *Step = StepVPV->getDefiningRecipe() ? State.get(StepVPV, 0)
+                                                 : StepVPV->getLiveInIRValue();
       Value *Escape =
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147963/new/

https://reviews.llvm.org/D147963