[PATCH] D149654: [SLP] Don't cost pointers that can be folded in getPointersChainCost

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfoImpl.h:1057
     // of costs of GEP instructions.
-    for (const Value *V : Ptrs) {
+    for (auto [i, V] : enumerate(Ptrs)) {
       const auto *GEP = dyn_cast<GetElementPtrInst>(V);
----------------
`I`


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfoImpl.h:1069
+            static_cast<T *>(this)->isLegalAddressingMode(
+                MemOpTy, nullptr, Stride * i, true, 0,
+                GEP->getType()->getPointerAddressSpace()))
----------------
Add a comment with the param name for the `true` argument


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149654/new/

https://reviews.llvm.org/D149654