[PATCH] D149552: [JITLink][RISCV] Fix logic for R_RISCV_ALIGN

Job Noorman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 30 08:57:49 PDT 2023


jobnoorman added a comment.

The required alignment is defined as <https://github.com/riscv-non-isa/riscv-elf-psabi-doc/blob/master/riscv-elf.adoc#relocation-for-alignment> `NextPowerOf2(Addend)` (as you changed it to) and I believe it should be ok to ignore the relocation if this value is `<=2` (not sure if this will actually happen in practice).

However, please not that I just submitted a patch to implement linker relaxation which also handles alignment properly: D149526 <https://reviews.llvm.org/D149526>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149552/new/

https://reviews.llvm.org/D149552



More information about the llvm-commits mailing list