[PATCH] D149002: [compiler-rt][interception][asan][win] Improve error reporting

Alvin Wong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 30 07:02:55 PDT 2023


alvinhochun marked an inline comment as done.
alvinhochun added inline comments.


================
Comment at: compiler-rt/lib/interception/tests/CMakeLists.txt:109
     RUNTIME ${INTERCEPTION_COMMON_LIB}
-    SOURCES ${INTERCEPTION_UNITTESTS} ${COMPILER_RT_GTEST_SOURCE}
+    SOURCES ${INTERCEPTION_UNITTESTS} ${COMPILER_RT_GTEST_SOURCE} ${INTERCEPTION_TEST_GMOCK_SOURCE}
     COMPILE_DEPS ${INTERCEPTION_TEST_HEADERS}
----------------
vitalybuka wrote:
> maybe add gmock on all platforms to have less conditions in CMake?
> 
Now the test doesn't require gmock.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149002/new/

https://reviews.llvm.org/D149002



More information about the llvm-commits mailing list