[PATCH] D148906: [AMDGPU] Remove function if FeatureWavefrontSize32 is not supported on current GPU

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 29 06:11:07 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/remove-incompatible-wave32-feature.ll:26
+define void @needs_wavefrontsize32(ptr %out) #0 {
+; GFX906-NOT:   define void @needs_wavefrontsize32(
+; GFX90A-NOT:   define void @needs_wavefrontsize32(
----------------
-NOT checks are fragile and should be as loose as possible. Drop the "define void" and trailing (


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148906/new/

https://reviews.llvm.org/D148906



More information about the llvm-commits mailing list