[PATCH] D148769: Split out `CodeGenTypes` from `CodeGen` for LLT/MVT

NAKAMURA Takumi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 29 01:41:00 PDT 2023


chapuni added a reviewer: dblaikie.
chapuni added a subscriber: dblaikie.
chapuni added a comment.

I am certain this works, though, I would like to ask the 2nd opinion to @dblaikie .

In D148769#4297552 <https://reviews.llvm.org/D148769#4297552>, @arsenm wrote:

> I feel like this should have documentation explaining the library split, but not sure where the best place to put that would be

I think better it may be put in front of `add_library(LLVMCodeGenTypes)`, at the moment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148769/new/

https://reviews.llvm.org/D148769



More information about the llvm-commits mailing list