[PATCH] D148328: [IRGen] Change annotation metadata to support inserting tuple of strings into annotation metadata array.

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 28 15:35:24 PDT 2023


paquette accepted this revision.
paquette added a comment.
This revision is now accepted and ready to land.

I have one nit but other than that this LGTM



================
Comment at: llvm/include/llvm/IR/Metadata.h:795
+  bool equalsStr(StringRef Str) const {
+    if (isa<MDString>(this->get()) &&
+        cast<MDString>(this->get())->getString() == Str)
----------------
just return this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148328/new/

https://reviews.llvm.org/D148328



More information about the llvm-commits mailing list