[PATCH] D148210: [InstCombine] Reassociate (C * X) * Y in foldICmpMulConstant

[Jun Zhang via Phabricator via llvm-commits]

junaire marked an inline comment as done.
junaire added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/icmp.ll:4970
 define i1 @mul_mul_sge_zero(i8 %a, i8 %b) {
 ; CHECK-LABEL: @mul_mul_sge_zero(
+; CHECK-NEXT:    [[TMP1:%.*]] = mul nsw i8 [[A:%.*]], [[B:%.*]]
----------------
goldstein.w.n wrote:
> I don't see any tests with `nuw` or for the comination of the flags.
Thanks, I added more tests. PTAL :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148210/new/

https://reviews.llvm.org/D148210