[PATCH] D149369: [RISCV] Consolidate legality checking for strided load/store [nfc]

Luke Lau via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 28 02:14:54 PDT 2023


luke accepted this revision.
luke added a comment.
This revision is now accepted and ready to land.

LGTM on my end



================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:15646
+  Type *ScalarType = DataType->getScalarType();
+  if (!isLegalElementTypeForRVV(ScalarType))
+    return false;
----------------
Maybe we could refactor `useRVVForFixedLengthVectors` to use MVTs and have the `Type` users call `getValueType`. But that's for another patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149369/new/

https://reviews.llvm.org/D149369



More information about the llvm-commits mailing list