[PATCH] D149033: [NFC]Fix 2 logic dead code

Wang, Xin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 27 20:05:46 PDT 2023


XinWang10 added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:5452
       // Get the exponent as a positive value.
       if ((int)Val < 0)
         Val = -Val;
----------------
skan wrote:
> Shouldn't we remove the cast too?
Sure, it should be.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149033/new/

https://reviews.llvm.org/D149033



More information about the llvm-commits mailing list